RFR (M): 8008772: remove gamma launcher

[Christian Thalinger]

On May 6, 2013, at 10:47 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:

> 
> Does the mainline webrev have navigation from file to file yet?
> 
> *src/share/tools/ProjectCreator/BuildConfig.java*
> Index <http://cr.openjdk.java.net/%7Etwisti/8008772/> Unified diffs <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.udiff.html> Context diffs <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.cdiff.html> Sdiffs <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.sdiff.html> Patch <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.patch> New <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java.html> Old <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/BuildConfig.java-.html> Previous File <http://cr.openjdk.java.net/%7Etwisti/8008772/src/os/windows/launcher/java_md.h.udiff.html> Next File <http://cr.openjdk.java.net/%7Etwisti/8008772/src/share/tools/ProjectCreator/WinGammaPlatformVC10.java.udiff.html>
> 
> That's why I use the custom webrev.

That's also the main reason why I use it.  Could we add that to the mainline version?  Although I'd rather see webrev disappear completely and be replaced with something more suitable for this century.

Anyway, I tried the latest in jdk8 and I don't see a difference:

http://cr.openjdk.java.net/~twisti/8008772/webrev/make/hotspot.script.html

-- Chris

> 
> Coleen
> 
> On 05/06/2013 01:40 PM, Mike Duigou wrote:
>> You may wish to sync your custom webrev script with the mainline webrev.ksh. It recently improved it's support for including a proper hg changeset rather than the patches that webrev has traditional generated. The improved changeset support handles hg copies and moves correctly whereas legacy webrev generated patches do not.
>> 
>> Mike
>> 
>> On May 6 2013, at 10:20 , Christian Thalinger wrote:
>> 
>>> On May 6, 2013, at 9:50 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>> 
>>>> Did you use 'hg rename' to move hotspot.script? We need to preserve history.
>>> hg move, yes.  An hg diff on my machine shows a diff:
>>> 
>>> cthaling at macbook:~/ws/8008772$ hg di make/hotspot.script
>>> diff --git a/src/os/posix/launcher/launcher.script b/make/hotspot.script
>>> copy from src/os/posix/launcher/launcher.script
>>> copy to make/hotspot.script
>>> --- a/src/os/posix/launcher/launcher.script
>>> +++ b/make/hotspot.script
>>> @@ -72,6 +72,7 @@
>>> REL_MYDIR=`dirname $0`
>>> MYDIR=`cd $REL_MYDIR && pwd`
>>> 
>>> +#
>>> # Look whether the user wants to run inside gdb
>>> case "$1" in
>>>     -gdb)
>>> @@ -95,16 +96,14 @@
>>> 
>>> -- Chris
>>> 
>>>> Thanks,
>>>> Vladimir
>>>> 
>>>> 
>>>> On 5/6/13 9:35 AM, Christian Thalinger wrote:
>>>>> Last warning!  If nobody speaks up today I'm going to push this later:
>>>>> 
>>>>> http://cr.openjdk.java.net/~twisti/8008772/
>>>>> 
>>>>> -- Chris
>>>>> 
>>>>> On May 2, 2013, at 5:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>> 
>>>>>> On May 2, 2013, at 5:25 PM, John Rose <john.r.rose at oracle.com> wrote:
>>>>>> 
>>>>>>> On May 2, 2013, at 4:44 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>>>> 
>>>>>>>> is anyone using env.{sh,csh}?
>>>>>>> I'll suggest that the answer is going to be "no".  I think very few people have ever used them.  — John
>>>>>> I think you're right.  Let's remove them with this change then.
>>>>>> 
>>>>>> -- Chris
>