RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly
Staffan Larsen
staffan.larsen at oracle.com
Wed May 8 01:58:13 PDT 2013
On 8 maj 2013, at 10:46, David Holmes <David.Holmes at oracle.com> wrote:
> Looks good to me Staffan!
Thanks.
> (Those methods should have been called getXXXCount not Counter though :( )
We can fix that at the same time: http://cr.openjdk.java.net/~sla/8013591/webrev.01/
/Staffan
>
> David
>
> On 8/05/2013 6:17 PM, Staffan Larsen wrote:
>> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>>
>> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>>
>> The fix is to check for null and return 0 as the counter value.
>>
>> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>>
>> Thanks,
>> /Staffan
>>
More information about the hotspot-dev
mailing list