RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly

Coleen Phillimore coleen.phillimore at oracle.com
Wed May 8 04:50:32 PDT 2013


This looks fine.   What tests did you run to find this bug?   I think 
Jiangli ran the sajdi and probably tmtools tests and the previous 
changes looked good to me.   They passed nightly which also should have 
exercised this code.   Can we add a test somewhere since the SA insists 
on bit-rotting with everything we touch?

thanks,
Coleen

On 5/8/2013 4:17 AM, Staffan Larsen wrote:
> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change.
>
> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated.
>
> The fix is to check for null and return 0 as the counter value.
>
> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591
>
> Thanks,
> /Staffan



More information about the hotspot-dev mailing list