RFR (S): CR 8012939: @Contended doesn't work correctly with inheritance

[Vladimir Kozlov]

You should send only one webrev then :)

Changes in webrev.01 are good.

Thanks,
Vladimir

PS: you need to become Hotspot committer to push your changes without our assistance. You should have enough changesets 
already.

On 5/15/13 12:22 AM, Aleksey Shipilev wrote:
> On 05/15/2013 11:19 AM, Aleksey Shipilev wrote:
>> On 05/15/2013 03:24 AM, Vladimir Kozlov wrote:
>>> On 5/14/13 3:24 PM, Aleksey Shipilev wrote:
>>>> Hi,
>>>>
>>>> It seems we have a plenty of failures in new SQE tests for @Contended
>>>> because of this. Please see the updated webrev for the issue:
>>>>     http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>>>>
>>>> This is the minimal fix. Most of the instance_size calculations use
>>>> first_nonstatic_field_offset as the boundary for the instance fields
>>>> block. @Contended on the class hijacks this boundary with padding, and
>>>> so the instance size is incorrect (also evidenced by the wrong assert).
>>>>
>>>> There is also a more thorough clean up of that code:
>>>>     http://cr.openjdk.java.net/~shade/8012939/webrev.02/
>>>
>>> I am fine with this version of the fix. But I would suggest more :)
>>> renaming.
>>
>> Sorry, but this will complicate the patch beyond graspable. Let's commit
>> the minimal fix, and work on the refactoring in the separate issue:
>>    http://cr.openjdk.java.net/~shade/8012939/webrev.01/
>
> To reiterate, this is *the* critical patch, and we desperately need this
> in the code. We had already wasted two weeks waiting for reviews, and I
> don't want this to drag along any further.
>
> -Aleksey.
>