RFR (XS) CR 8014509: @Contended: explicit default value behaves differently from the implicit value

Christian Tornqvist christian.tornqvist at oracle.com
Wed May 15 12:33:26 PDT 2013


Hi Aleksey,

Test name and location should be something more descriptive, more
information about the Hotspot jtreg naming convention can be found at:

https://wikis.oracle.com/display/HotSpotInternals/Naming+HotSpot+JTReg+Tests

Thanks,
Christian

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net
[mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Aleksey Shipilev
Sent: den 15 maj 2013 11:36
To: hotspot-dev at openjdk.java.net
Subject: RFR (XS) CR 8014509: @Contended: explicit default value behaves
differently from the implicit value

Hi,

Please review the little parameter handling fix for @Contended:
  http://cr.openjdk.java.net/~shade/8014509/webrev.01/

Bottom-line, these guys should be equivalent:
 public class Test {
    private static class T0 {
        @Contended("") private double double1;
        @Contended("") private double double2;
    }
    private static class T1 {
        @Contended()   private double double1;
        @Contended()   private double double2;
    }
    private static class T2 {
        @Contended     private double double1;
        @Contended     private double double2;
    }
}

They are not, because we handle the default value in a weird way.

Testing:
  - 8014509 regression test on Linux x86_64/fastdebug
  - full JPRT cycle against hotspot-rt

Thanks,
Aleksey.






More information about the hotspot-dev mailing list