RFR (S): CR 8012939: @Contended doesn't work correctly with inheritance

[John Rose]

On May 14, 2013, at 3:24 PM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> It seems we have a plenty of failures in new SQE tests for @Contended
> because of this. Please see the updated webrev for the issue:
>  http://cr.openjdk.java.net/~shade/8012939/webrev.01/
> 
> This is the minimal fix.

Aleksey, you can count me as a reviewer on the minimal fix.

Sadly, I (like Vladimir) have spent too much time learning the spaghetti code that does class file layout.  This makes it hard to easily evaluate the benefits of the renaming you propose.

I have always thought that this code should be factored into small structs.  It seems to me that renaming has limited value given the large number of state variables.

(Reminds me of a 1970's implementation of the Star Trek game in Basic, but with longer names.)

— John