RFR (XS) CR 8014509: @Contended: explicit default value behaves differently from the implicit value

Aleksey Shipilev aleksey.shipilev at oracle.com
Thu May 16 14:59:41 PDT 2013


On 05/17/2013 01:52 AM, Christian Thalinger wrote:
> Looks good.  -- Chris
> 
> On May 16, 2013, at 2:25 PM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> 
>> On 05/17/2013 12:50 AM, Vladimir Kozlov wrote:
>>> You forgot to change != to ==
>>>
>>> +        if (_cp->symbol_at(group_index)->utf8_length() != 0) {
>>> +          group_index = 0; // default contended group
>>>
>>> Otherwise it is good. Thank you for the comment.
>>
>> Darn. Now I see why test renamings are good: it had actually regressed
>> the 8003985 test.
>>
>> Fixed:
>>  http://cr.openjdk.java.net/~shade/8014509/webrev.03/
>>
>> We need the second reviewer.

Great, thanks.

Any sponsors around? :) Please push:
 http://cr.openjdk.java.net/~shade/8014509/8014509.changeset

-Aleksey.



More information about the hotspot-dev mailing list