RFR (S) CR 8014878: Clean up class field layout code

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon May 20 09:29:06 PDT 2013


Looks good.

Could you fix indentions in lines 3176 (move 1 space left), 3572 (move 1 
space right)?

Thanks,
Vladimir

PS: Aleksey, I am stating process to make you Hotspot Committer (HSX 
Author first) because you have already 9 changesets in our sources:

http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/log?rev=aleksey.shipilev%40oracle.com
http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/571076d3c79d


On 5/20/13 8:57 AM, Aleksey Shipilev wrote:
> Hi,
>
> This is the cleanup I promised to do for the CL code.
>
> The first batch is here:
>    http://cr.openjdk.java.net/~shade/8014878/webrev.01/
>
> I would like to do this in incremental steps to ease the bisecting
> should it bring any regressions. If you think something else needs the
> refactoring, speak up, I'll add this to running tally of things to clean
> up in the next patch.
>
> Testing:
>    - test/runtime/contended regression tests
>    - full JPRT cycle vs hotspot-rt
>
> Please review!
>
> -Aleksey.
>


More information about the hotspot-dev mailing list