RFR (S) CR 8014878: Clean up class field layout code

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon May 20 19:03:47 PDT 2013


The job in JPRT queue.

Vladimir

On 5/20/13 12:46 PM, Aleksey Shipilev wrote:
> On 05/20/2013 10:31 PM, Coleen Phillimore wrote:
>>
>> On 05/20/2013 01:33 PM, Aleksey Shipilev wrote:
>>> On 05/20/2013 08:29 PM, Vladimir Kozlov wrote:
>>>> Looks good.
>>> Thanks for the review!
>>>
>>>> Could you fix indentions in lines 3176 (move 1 space left), 3572 (move 1
>>>> space right)?
>>> Done:
>>>    http://cr.openjdk.java.net/~shade/8014878/webrev.02/
>>>
>>> We still need a second reviewer, right?
>>> Coleen, I bet you are anxious to see that method being refactored.
>>
>> This looks good and helpful.
>
> Thanks for the review!
>
> The changeset is here:
>    http://cr.openjdk.java.net/~shade/8014878/8014878.01.changeset
>
> Please sponsor :)
>
> -Aleksey.
>


More information about the hotspot-dev mailing list