RFR (S) CR 8014886: @Contended fields can overrun oop maps

Aleksey Shipilev aleksey.shipilev at oracle.com
Tue May 21 01:50:23 PDT 2013


On 05/21/2013 08:17 AM, Vladimir Kozlov wrote:
> On 5/20/13 7:26 PM, David Holmes wrote:
>> Hi Aleksey,
>>
>> What value does max_oop_maps get? And how does that compare to the old
> 
> max_oop_maps = fac->count[NONSTATIC_OOP] is the same as before
> @Contended changes were added. Aleksey restored original correct value.
> 
>> value of "nonstatic_oop_count + 1"? I'm just trying to get a sense of
> 
> I don't remember why I had (nonstatic_oop_count + 1) in my original
> changes from few years ago. May be because resource allocation code
> complained about size == 0 (when nonstatic_oop_count == 0). Or when we
> allocate with UseMallocOnly.

I was puzzled about this one as well; traced down the code looking for
the uses beyond the limit, found none. This hack for zero allocations
intrigues me... so, I will return +1 in this changeset, and then submit
another CR for pruning it (this will allow us to have proper regression
test).

-Aleksey.


More information about the hotspot-dev mailing list