review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

[JOSEPH PROVINO]

On 5/21/2013 2:49 AM, Staffan Larsen wrote:
> On 21 maj 2013, at 04:34, David Holmes <David.Holmes at oracle.com> wrote:
>
>> <added servicability>
>>
>> Hi Joe,
>>
>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef.
>>
>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value?
> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error.

Okay, it sounds like I should abandon this approach and look into 
removing the symbol from the symbol files.

>
> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented.

Sounds like returning an error isn't a good idea...

joe

>
> /Staffan
>
>> Thanks,
>> David
>>
>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote:
>>> The change is to include forte.cpp in the minimal jvm but to
>>> conditionalize the code so that
>>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>>
>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>>
>>>   * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>>     a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>>     minimal/libjvm.a when DEBUG_LEVEL == release
>>>     <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>>
>>> Thanks.
>>>
>>> joe
>>>
>>>