review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

[JOSEPH PROVINO]

On 5/20/2013 3:51 PM, serguei.spitsyn at oracle.com wrote:
> Hi Joe,
>
> src/share/vm/prims/forte.cpp
>
>
> These are new lines added unconditionally:
>    38 // call frame copied from old .h file and renamed
>    39 typedef struct {
>    40     jint lineno;                      // line number in the source file
>    41     jmethodID method_id;              // method executed in this frame
>    42 } ASGCT_CallFrame;
>    43
>    44 // call trace copied from old .h file and renamed
>    45 typedef struct {
>    46     JNIEnv *env_id;                   // Env where trace was recorded
>    47     jint num_frames;                  // number of frames in this trace
>    48     ASGCT_CallFrame *frames;          // frames
>    49 } ASGCT_CallTrace;
>    50
>
> Should the following lines (under #if INCLUDE_JVMTI) be removed ? :

Yes, I fixed that.  I'll put out another webrev.

>   379 // call frame copied from old .h file and renamed
>   380 typedef struct {
>   381     jint lineno;                      // line number in the source file
>   382     jmethodID method_id;              // method executed in this frame
>   383 } ASGCT_CallFrame;
>   384
>   385 // call trace copied from old .h file and renamed
>   386 typedef struct {
>   387     JNIEnv *env_id;                   // Env where trace was recorded
>   388     jint num_frames;                  // number of frames in this trace
>   389     ASGCT_CallFrame *frames;          // frames
>   390 } ASGCT_CallTrace;
>   391
>
> Did you build the fix for non-minimal VM configuration?

I did with the new changes.

thanks.

joe

>
> Other than that the fix looks good.
> It'd be nice if Dan reviewed it too.
>
>
> Thanks,
> Serguei
>
>
> On 5/20/13 12:10 PM, JOSEPH PROVINO wrote:
>> The change is to include forte.cpp in the minimal jvm but to 
>> conditionalize the code so that
>> only AsyncGetCallTrace() is defined with the minimal jvm.
>>
>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/
>>
>>  * JDK-8013461 <https://jbs.oracle.com/bugs/browse/JDK-8013461>There is
>>    a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in
>>    minimal/libjvm.a when DEBUG_LEVEL == release
>> <https://jbs.oracle.com/bugs/browse/JDK-8013461>
>>
>> Thanks.
>>
>> joe
>>
>>
>