RFR (S) CR 8014886: @Contended fields can overrun oop maps

[Coleen Phillimore]

Thank you!  I look forward to seeing the cleaned up code.
Coleen

On 05/23/2013 02:07 AM, Aleksey Shipilev wrote:
> On 05/23/2013 04:27 AM, Coleen Phillimore wrote:
>>> I have to say that the number of deferrals of issues to new bugs
>>> during a current bug's review cycle along with the general bug
>>> tail of @Contended is making me very nervous. It's starting to feel
>>> like we're just stumbling around wearing a bucket and have a very
>>> limited view of the horizon due to the bucket.
>> I interpret this as a second request to fix all the bugs and
>> cleanups in one change and let us review that change.
> Thanks, I will comply with this request.
>
> I would like to note that requests using the form of "please merge all
> bugfixes and cleanups into the single CR" are more effective as the
> communication means, rather than relying on other reviewers to
> re-interpret what is being requested. :)
>
> For the record, I still think this is a bad idea to merge the histories
> for several related, but distinct issues together, even if the changes
> are small, on the pretense it makes the bulk review easier. But, as I
> said, will disagree and commit.
>
>> I don't think it needs to be backed out because it only affects the
>> contended tests and that's not in the JDK yet (or is it?)   Is it
>> breaking code that doesn't use it?
> There is no @Contended classes/fields in JDK (yet). We are waiting for
> this VM code to stabilize before committing to @Contended in the library.
>
> -Aleksey.