Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Fri May 24 10:08:47 PDT 2013
John,
Thank you for the review.
I'm taking a suggestion from Mikael G.
Thanks,
Serguei
On 5/24/13 7:37 AM, Jon Masamitsu wrote:
> Serguei,
>
> I think the change is correct but would it be a problem
> to just take the MemberNameTable_lock whether
> at a safepoint or not?
>
> Jon
>
> On 5/24/2013 2:29 AM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>> bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/
>>
>>
>> Summary:
>> CMS calls InstanceKlass::release_C_heap_structures() concurrently.
>> The "delete mnt" needs to take MemberNameTable_lock if
>> !SafepointSynchronize::is_at_safepoint().
>>
>> Testing:
>> The vm/mlvm and Nashorn tests, the tests listed in the bug report
>>
>> Thanks,
>> Serguei
>
More information about the hotspot-dev
mailing list