Review request: 8015428: Remove unused CDS support from StringTable

[Per Lidén]

Hi Stefan,

On 2013-05-27 13:35, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>
>   <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428
> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>: Remove
> unused CDS support from StringTable
> Summary: The string in StringTable is not used by CDS anymore. Remove
> the unnecessary code in preparation for8015422
> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large
> performance hit when the StringTable is walked twice in Parallel Scavenge
>
> Tested with JPRT and ad-hoc benchmark allocating and deallocating
> interned Strings with and without -Xshare.

Looks good (not a reviewer), just one minor thing. Calling make_ptr() 
only makes sense if you have shared entries, so in unlink():

entry = (HashtableEntry<oop, mtSymbol>*)HashtableEntry<oop, 
mtSymbol>::make_ptr(*p);

could be;

entry = *p;

and in oops_do():

entry = (HashtableEntry<oop, mtSymbol>*)HashtableEntry<oop, 
mtSymbol>::make_ptr(entry->next());

could be:

entry = entry->next();

(actually, next() calls make_ptr() anyway before returning the next 
entry, but let's ignore that...)

/Per