Review request: 8015428: Remove unused CDS support from StringTable
Stefan Karlsson
stefan.karlsson at oracle.com
Tue May 28 12:54:24 PDT 2013
On 5/28/13 9:22 PM, Coleen Phillmore wrote:
>
> Thanks Christian for the info. Code looks good.
Thanks, Coleen!
StefanK
> Coleen
>
> On 5/28/2013 2:47 PM, Stefan Karlsson wrote:
>> On 5/28/13 8:35 PM, Christian Thalinger wrote:
>>> On May 27, 2013, at 4:35 AM, Stefan Karlsson
>>> <stefan.karlsson at oracle.com> wrote:
>>>
>>>> http://cr.openjdk.java.net/~stefank/8015428/webrev.00/
>>>>
>>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>8015428
>>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015428>:
>>>> Remove unused CDS support from StringTable
>>>> Summary: The string in StringTable is not used by CDS anymore.
>>>> Remove the unnecessary code in preparation for8015422
>>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015422>: Large
>>>> performance hit when the StringTable is walked twice in Parallel
>>>> Scavenge
>>> I'm adding interned strings back to CDS right now with 8015086. The
>>> changes should be okay though since I'll have two string tables then
>>> and we only need to walk the dynamic one.
>> Great!
>>
>> thanks,
>> StefanK
>>
>>>
>>> -- Chris
>>>
>>>> Tested with JPRT and ad-hoc benchmark allocating and deallocating
>>>> interned Strings with and without -Xshare.
>>>>
>>>> thanks,
>>>> StefanK
>>>>
>>
>
More information about the hotspot-dev
mailing list