RFR (S): 8028401: PPC (part 117): Improve usability of adlc and format() functionality.

[Vladimir Kozlov]

Good.

I will push it after 8024921.

Thanks,
Vladimir

On 11/15/13 1:58 AM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
>
> I removed the version without const.
>
> Best regards,
>    Goetz.
>
> -----Original Message-----
> From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: Freitag, 15. November 2013 04:16
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR (S): 8028401: PPC (part 117): Improve usability of adlc and format() functionality.
>
> Do we really need 2 version of constant_offset_unchecked()? It is used
> only in format() const.
>
> Vladimir
>
> On 11/14/13 2:04 PM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> This change contains some smaller additions to adlc and the format() routine,
>> that improve their usability:
>> http://cr.openjdk.java.net/~goetz/webrevs/8028401-0-adlc/
>>
>> Improve usability of adlc:
>> So far, expands can only use instructs that are specified further up in the .ad file.
>> This is because the check whether nodes used in the expand are also defined
>> is done during parsing.
>> Move this check to a later point to relax ordering constraints.
>>
>> Add a row of additional, more verbose syntax checks.
>>
>> Improve format():
>> If MachNode::format() is called before constants are written to the
>> constants section, it can fail. Add a safer version of constant_offset
>> to avoid this.
>>
>> Please review and test this change.
>>
>> Best regards,
>>     Goetz.
>>