RFR: 8029329: tmtools tests fail with NPE (in the tool) when run with G1 and FlightRecorder

Mikael Gerdin mikael.gerdin at oracle.com
Fri Nov 29 06:57:29 PST 2013


Stefan,

On Friday 29 November 2013 14.26.10 Stefan Johansson wrote:
> Hi,
> 
> Please review this fix for:
> https://bugs.openjdk.java.net/browse/JDK-8029329
> 
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8029329/webrev.00/

Typo:
+    // uint _allocated_lenght


Otherwise the change looks good.

/Mikael

> 
> Summary:
> The iterator used by the SA for walking through G1s heap regions used
> the total number of regions as the limit for hasNext. This caused a
> NullPointerException when reaching the first unallocated region. Updated
> the SA to initialize the iterator with the currently allocated number of
> regions as limit instead.
> 
> Testing:
> * Tested builds through JPRT
> * Ran vm.tmtools.testlist throught Aurora and observed no failures on
> the test I expected to pass.
> 
> Thanks,
> Stefan



More information about the hotspot-dev mailing list