Review request: (turn off transparent huge pages) 8024838: Significant slowdown due to transparent huge pages

[Stefan Karlsson]

On 2013-10-04 09:01, Jesper Wilhelmsson wrote:
> Looks good!

Thanks, Jesper.

>
> Is there a reason to why you chose not to use SET_FLAG_ERGO when 
> updating the flags? If not I would prefer if the macro was used.

I wanted to minimize the risk that some other code looking at the large 
pages flags would fail if I started to use the SET_FLAG macros.

thanks,
StefanK

> /Jesper
>
>
> Stefan Karlsson skrev 3/10/13 9:40 PM:
>> Please review this change to turn off transparent huge pages by default.
>>
>> http://cr.openjdk.java.net/~stefank/8024838/webrev.00/
>>
>> 8024838: Significant slowdown due to transparent huge pages
>> Summary: Don't turn on transparent huge pages 
>> (-XX:+UseTransparentHugePages)
>> unless explicitly specified on the command line. This has the effect 
>> that large
>> pages are never turned on Linux unless the user has explicitly 
>> enabled any of
>> the large pages flags: -XX:+UseLargePages, -XX:+UseTransparentHugePages,
>> -XX:+UseHugeTLBFS, and -XX:+UseSHM.
>> Reviewed-by: TBD1, TBD2
>>
>> thanks,
>> StefanK