RFR(S): 8025942: Implement os::Bsd:available_memory
Daniel D. Daugherty
daniel.daugherty at oracle.com
Fri Oct 11 09:44:49 PDT 2013
>
http://cr.openjdk.java.net/~dsamersoff/sponsorship/gziemski/JDK-8025942/webrev.01/
src/os/bsd/vm/os_bsd.cpp
nit line 166 kern_return_t kerr =
host_statistics64(mach_host_self(), HOST_VM_INFO64,
(host_info64_t)&vmstat, &count);
This line is longer than 80 chars. Please reformat it
to something like:
166 kern_return_t kerr = host_statistics64(mach_host_self(),
HOST_VM_INFO64,
(host_info64_t)&vmstat, &count);
Thumbs up.
Dan
On 10/10/13 1:14 PM, Gerard Ziemski wrote:
> Please review this fix that implements os::Bsd:available_memory()
>
> Description:
>
> This is a simple change - we use a similar implementation that Apple
> itself uses (see
> http://opensource.apple.com/source/system_cmds/system_cmds-498.2/vm_stat.tproj/vm_stat.c)
> to implement BSD (Apple platform only) implementation for finding out
> available (free) memory.
>
>
> Testing:
>
> Passed JPRT, vm quicklooks
>
>
> References:
>
> http://cr.openjdk.java.net/~dsamersoff/sponsorship/gziemski/JDK-8025942/webrev.01/
>
> https://bugs.openjdk.java.net/browse/JDK-8025942
>
>
> cheers
>
>
>
More information about the hotspot-dev
mailing list