RFR(XS): 8026703 : Wrongly placed <xsl:import> element in Event-Based JVM Tracing .xsl files

[Volker Simonis]

Hi Keith, Staffan,

thanks for the review.

@Staffan: can you please push this. I think this should go right into
hotspot-rt because it is not port relevant.

Thanks,
Volker


On Wed, Oct 16, 2013 at 4:29 PM, Staffan Larsen
<staffan.larsen at oracle.com> wrote:
> Looks good!
>
> Thanks,
> /Staffan
>
> On 16 okt 2013, at 15:18, Volker Simonis <volker.simonis at gmail.com> wrote:
>
>> Hi,
>>
>> could somebody please review and push the following small fix:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8026703/
>> https://bugs.openjdk.java.net/browse/JDK-8026703
>>
>> Some background information:
>>
>> The three XSL files
>>
>> src/share/vm/trace/traceEventClasses.xsl
>> src/share/vm/trace/traceEventIds.xsl
>> src/share/vm/trace/traceTypes.xsl
>>
>> contain <xsl:import> elements after <xsl:output> elements. This is not
>> allowed, because according to the XSLT specification
>> (http://www.w3.org/TR/xslt#element-import) "xsl:import element
>> children must precede all other element children of an xsl:stylesheet
>> element".
>>
>> I do not know why the current OpenJDK XSLT processor doesn't object
>> this (and maybe this should be the topic of another Bug/RFE), but
>> other XSLT processors (i.e. the one in IBM J9) do care and this leads
>> to build failures if building with a non-Oracle boot JDK.
>>
>> The fix is easy - just reorder the <xsl:import> elements before the
>> <xsl:output> elements.
>>
>> Regards,
>> Volker
>