Test webrev review please: Re: RFR ASAP please: 8026365: Fix verifier for anonymous classes

[Daniel D. Daugherty]

I'm guessing that you mean this webrev:

 > http://cr.openjdk.java.net/~acorn/8026365.test/webrev/

src/share/vm/classfile/verifier.cpp
     This webrev is against the current T&L/hotspot version instead
     of the version that is being sync'ed down from JDK8.

test/TEST.groups
     runtime/8026365/InvokeSpecialAnonTest.java is added to this list
     but is not included in the webrev.

     Why is runtime/6878713/Test6878713.sh deleted in this webrev?

Dan




On 10/17/13 12:17 PM, Karen Kinnear wrote:
> Added test (thanks to Robert Field). Please review:
>
>
>
>
> thanks,
> Karen
>
> On Oct 17, 2013, at 12:13 AM, Karen Kinnear wrote:
>
>> Please review quickly:
>>
>> webrev: http://cr.openjdk.java.net/~acorn/8026365/webrev/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8026365
>>
>> Verifier called is_reference_assignable, which called resolve_or_null, which was looking for
>> the anonymous class in the system dictionary, where it is not. So this will allow more anonymous
>> class cases to get through the verifier while still doing validity checking (but on the host class only,
>> not on the anonymous class).
>>
>> Tested:
>> Robert's new test: reduct (which he will check in as part of the lambda side of this change)
>> Lam
>> Lam1
>>
>> in progress: vm.quick, java.lang, java.util, Nashorn
>>
>> thanks,
>> Karen
>>
>> p.s. Alejandro, Dan, Calvin - they want this in TL ASAP - should I check this directly into hotspot-master tomorrow?
>>
>> p.s. Vincente - can you grab this patch to test with Robert's changes please? I tested with the patches he
>> had given me
>>