Test webrev review please: Re: RFR ASAP please: 8026365: Fix verifier for anonymous classes

[Daniel D. Daugherty]

On 10/17/13 3:41 PM, Karen Kinnear wrote:
> Test webrev: http://cr.openjdk.java.net/%7Eacorn/8026365.test/webrev/

test/TEST.groups
     No comments.

test/runtime/8026365/InvokeSpecialAnonTest.java
     line 32: * @run main/othervm -Xbootclasspath/a:. -Xverify:all 
InvokeSpecialAnonTest

         I thought the '-Xbootclasspath/a:.' part wasn't working?
         Or did this: '-XDignore.symbol.file' make things happy again?

Thumbs up.

The removal of 6878713/Test6878713.sh was done via:

changeset:   5391:d574419c5372
user:        mseledtsov
date:        Wed Oct 02 15:17:20 2013 +0200
summary:     8025671: Test name changed, test list not updated. 
Test6878713.sh

which is in JDK8-B112/HSX-25-B54 so you'll pickup that change
when you merge with Lana's sync-down from JDK8.

Dan


>
> Note I removed 6878713/Test6878713.sh from the TEST.groups file
> because the directory no longer exists and this prevents other tests 
> from running.
>
> thanks,
> Karen
>
> On Oct 17, 2013, at 5:30 PM, Daniel D. Daugherty wrote:
>
>> On 10/17/13 2:41 PM, Karen Kinnear wrote:
>>> No - I attached the file directly.
>>
>> So the attach probably worked for everyone that was a direct
>> recipient. However, for those (like me) that got the e-mail
>> via hotspot-dev at openjdk.java.net, the attachment got stripped.
>>
>>
>>> I couldn't figure out how to get webrev to show a new file without
>>> doing a commit.
>>
>> An "hg add test/runtime/8026365/InvokeSpecialAnonTest.java"
>> should do the trick or just pass a file list to webrev
>> that includes test/runtime/8026365/InvokeSpecialAnonTest.java
>> and I _think_ that'll do it also.
>>
>> Dan
>>
>>
>>
>>> So I didn't use the webrev for review - but thanks for looking at it 
>>> - because I
>>> forgot to send the TEST.groups. If I understand correctly, we now 
>>> need to add to that whenever adding
>>> a test that needs the full jdk as this one does for the asm library.
>>>
>>> That said - I had to change test/TEST.groups in order to run my test 
>>> - because the test itself
>>> doesn't exist and the new mechanism to split things based on 
>>> profiles seems intolerant - i.e. it doesn't
>>> just report a problem and continue - it stops dead in its tracks. 
>>> I'm sure David H will be delighted to fix that.
>>>
>>>
>>> On Oct 17, 2013, at 3:41 PM, Daniel D. Daugherty wrote:
>>>
>>>> I'm guessing that you mean this webrev:
>>>>
>>>> > http://cr.openjdk.java.net/~acorn/8026365.test/webrev/
>>>>
>>>> src/share/vm/classfile/verifier.cpp
>>>>     This webrev is against the current T&L/hotspot version instead
>>>>     of the version that is being sync'ed down from JDK8.
>>>>
>>>> test/TEST.groups
>>>>     runtime/8026365/InvokeSpecialAnonTest.java is added to this list
>>>>     but is not included in the webrev.
>>>>
>>>>     Why is runtime/6878713/Test6878713.sh deleted in this webrev?
>>>>
>>>> Dan
>>>>
>>>>
>>>>
>>>>
>>>> On 10/17/13 12:17 PM, Karen Kinnear wrote:
>>>>> Added test (thanks to Robert Field). Please review:
>>>>>
>>>>>
>>>>>
>>>>> thanks,
>>>>> Karen
>>>>>
>>>>> On Oct 17, 2013, at 12:13 AM, Karen Kinnear wrote:
>>>>>
>>>>>> Please review quickly:
>>>>>>
>>>>>> webrev:http://cr.openjdk.java.net/~acorn/8026365/webrev/
>>>>>> bug:https://bugs.openjdk.java.net/browse/JDK-8026365
>>>>>>
>>>>>> Verifier called is_reference_assignable, which called resolve_or_null, which was looking for
>>>>>> the anonymous class in the system dictionary, where it is not. So this will allow more anonymous
>>>>>> class cases to get through the verifier while still doing validity checking (but on the host class only,
>>>>>> not on the anonymous class).
>>>>>>
>>>>>> Tested:
>>>>>> Robert's new test: reduct (which he will check in as part of the lambda side of this change)
>>>>>> Lam
>>>>>> Lam1
>>>>>>
>>>>>> in progress: vm.quick, java.lang, java.util, Nashorn
>>>>>>
>>>>>> thanks,
>>>>>> Karen
>>>>>>
>>>>>> p.s. Alejandro, Dan, Calvin - they want this in TL ASAP - should I check this directly into hotspot-master tomorrow?
>>>>>>
>>>>>> p.s. Vincente - can you grab this patch to test with Robert's changes please? I tested with the patches he
>>>>>> had given me
>>>>>>
>>>>
>>>
>>
>