Test webrev review please: Re: RFR ASAP please: 8026365: Fix verifier for anonymous classes

[Karen Kinnear]

David,

InvokeSpecialAnonTest.java needs the jdk to provide objectweb.asm to build, in fact it needed a special flag to
find it. But let me know if that is in one of the smaller profiles - I don't know where to look that up.

I will retry the missing test directory and get back to you on that. Sounds like I was mistaken (?)

thanks,
Karen

On Oct 17, 2013, at 11:06 PM, David Holmes wrote:

> On 18/10/2013 6:41 AM, Karen Kinnear wrote:
>> No - I attached the file directly. I couldn't figure out how to get webrev to show a new file without
>> doing a commit. So I didn't use the webrev for review - but thanks for looking at it - because I
>> forgot to send the TEST.groups. If I understand correctly, we now need to add to that whenever adding
>> a test that needs the full jdk as this one does for the asm library.
>> 
>> That said - I had to change test/TEST.groups in order to run my test - because the test itself
>> doesn't exist and the new mechanism to split things based on profiles seems intolerant - i.e. it doesn't
>> just report a problem and continue - it stops dead in its tracks. I'm sure David H will be delighted to fix that.
> 
> Not sure what you mean. If a group lists a test that doesn't exist then jtreg will report that while parsing the groups file but otherwise it is ignored.
> 
> BTW I don't see why InvokeSpecialAnonTest.java is listed as needs_jdk ??
> 
> David
> -----
> 
>> 
>> On Oct 17, 2013, at 3:41 PM, Daniel D. Daugherty wrote:
>> 
>>> I'm guessing that you mean this webrev:
>>> 
>>>> http://cr.openjdk.java.net/~acorn/8026365.test/webrev/
>>> 
>>> src/share/vm/classfile/verifier.cpp
>>>     This webrev is against the current T&L/hotspot version instead
>>>     of the version that is being sync'ed down from JDK8.
>>> 
>>> test/TEST.groups
>>>     runtime/8026365/InvokeSpecialAnonTest.java is added to this list
>>>     but is not included in the webrev.
>>> 
>>>     Why is runtime/6878713/Test6878713.sh deleted in this webrev?
>>> 
>>> Dan
>>> 
>>> 
>>> 
>>> 
>>> On 10/17/13 12:17 PM, Karen Kinnear wrote:
>>>> Added test (thanks to Robert Field). Please review:
>>>> 
>>>> 
>>>> 
>>>> 
>>>> thanks,
>>>> Karen
>>>> 
>>>> On Oct 17, 2013, at 12:13 AM, Karen Kinnear wrote:
>>>> 
>>>>> Please review quickly:
>>>>> 
>>>>> webrev: http://cr.openjdk.java.net/~acorn/8026365/webrev/
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8026365
>>>>> 
>>>>> Verifier called is_reference_assignable, which called resolve_or_null, which was looking for
>>>>> the anonymous class in the system dictionary, where it is not. So this will allow more anonymous
>>>>> class cases to get through the verifier while still doing validity checking (but on the host class only,
>>>>> not on the anonymous class).
>>>>> 
>>>>> Tested:
>>>>> Robert's new test: reduct (which he will check in as part of the lambda side of this change)
>>>>> Lam
>>>>> Lam1
>>>>> 
>>>>> in progress: vm.quick, java.lang, java.util, Nashorn
>>>>> 
>>>>> thanks,
>>>>> Karen
>>>>> 
>>>>> p.s. Alejandro, Dan, Calvin - they want this in TL ASAP - should I check this directly into hotspot-master tomorrow?
>>>>> 
>>>>> p.s. Vincente - can you grab this patch to test with Robert's changes please? I tested with the patches he
>>>>> had given me
>>>>> 
>>> 
>>