Fwd: RFR (S): 8022229: Intermittent test failures in sun/tools/jstatd

[Yekaterina Kantserova]

Sorry, the wrong webrev link has slipped through.

Here is the right one:

http://cr.openjdk.java.net/~ykantser/8022229/webrev.01/

Thanks,
Katja



On 10/21/2013 05:23 PM, Yekaterina Kantserova wrote:
> Hi,
>
> I've done following changes after the reviews:
> - added open copyrights
> - documented all public functions in jdk.testlibrary.TestThread, 
> jdk.testlibrary.XRun, jdk.testlibrary.ProcessThread, jdk.testlibrary.Utils
> - merged jdk.testlibrary.Asserts from hotspot testlibrary
>
> Jaroslav's comments:
> - test/sun/tools/jstatd/JstatdHelper.java 82-84 - is deleted, 
> different exception can show up there while waiting until jstatd is up 
> and running; better just look for valid pid;
> - test/sun/tools/jstatd/JstatdHelper.java clean up processes - since 
> jstatd process is daemon, the "clean up" is to kill the target 
> process. Please look at the changed JstatdHelper and tell me if it's 
> still unclear.
> - test/lib/testlibrary/jdk/testlibrary/Utils.java serverSocket.close() 
> should be called in "finally" - fixed
>
> Webrev:
> http://cr.openjdk.java.net/~ykantser/8022229/webrev.01/
>
> Primal bug:
> https://bugs.openjdk.java.net/browse/JDK-8022229
>
> Similar bugs:
> https://bugs.openjdk.java.net/browse/JDK-8019630
> https://bugs.openjdk.java.net/browse/JDK-6636094
> https://bugs.openjdk.java.net/browse/JDK-6543979
>
> Thanks,
> Katja