RFR (S): 8024379: Adapt PPC64 port to 8003424

harold seigel harold.seigel at oracle.com
Fri Sep 6 06:52:11 PDT 2013


Hi Goetz,

Your changes look good.

Do you need changes similar to 
http://cr.openjdk.java.net/~hseigel/bug_8003424.4/src/cpu/x86/vm/vtableStubs_x86_64.cpp.udiff.html 
<http://cr.openjdk.java.net/%7Ehseigel/bug_8003424.4/src/cpu/x86/vm/vtableStubs_x86_64.cpp.udiff.html> 
because the number of decoding/encoding instructions have increased?

Thanks, Harold

On 9/6/2013 8:00 AM, Lindenmaier, Goetz wrote:
> Hi Coleen,
>
> thanks for the review!
> I know about the changes required in .ad.  I don't need them yet, as
> the compiler stuff is not yet in the staging repository.
>
> Best regards,
>    Goetz.
>
> -----Original Message-----
> From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
> Sent: Freitag, 6. September 2013 13:46
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR (S): 8024379: Adapt PPC64 port to 8003424
>
>
> Goetz,
>
> This change looks good.   There was another .ad file change associated
> with the new code that you are merging with but I don't know if you have
> the same code.
>
> Coleen
>
> On 9/6/2013 4:21 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> Syncing 8003424 to the ppc64 staging repository breaks the code so far
>> contributed. This is fixed by this change.
>> http://cr.openjdk.java.net/~goetz/webrevs/8024379/
>>
>> The change is ppc64 only.
>>
>> Please review this change.  I will commit it then before Volker adds
>> the aix changes.
>>
>> Best regards,
>>     Goetz



More information about the hotspot-dev mailing list