RFR (XS): 8023134: Rename VM LogFile to hotspot_pid{pid}.log (was hotspot.log)

[Vladimir Ivanov]

Thanks for catching this! Updated the webrev.

Best regards,
Vladimir Ivanov

On 9/9/13 9:59 PM, Vladimir Kozlov wrote:
> You missed LogCompilation/README, otherwise it is good.
>
> Thanks,
> Vladimir
>
> On 9/9/13 10:27 AM, Vladimir Ivanov wrote:
>> Vladimir K.,
>>
>> Thanks for looking into this.
>>
>> How about this?
>> http://cr.openjdk.java.net/~vlivanov/8023134/webrev.01
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 9/9/13 8:59 PM, Vladimir Kozlov wrote:
>>> Vladimir,
>>>
>>> Move last FREE_C_HEAP_ARRAY() after 'if' body instead of having it on
>>> both branches.
>>> There are several comments in sources which mention hotspot.log. I think
>>> they need to be changes. Especially in globals.hpp
>>>
>>> Thanks,
>>> Vladimir K
>>>
>>> On 9/9/13 4:24 AM, Vladimir Ivanov wrote:
>>>> http://cr.openjdk.java.net/~vlivanov/8023134/webrev.00/
>>>> 7 lines changed: 4 ins; 0 del; 3 mod
>>>>
>>>> Added pid of the Java process to default name of VM log file:
>>>>      - old: hotspot.log
>>>>      - new: hotspot_pid{pid}.log
>>>>
>>>> It allows to avoid hotspot.log overwrite/corruption in multi-VM test
>>>> scenarios and simplifies
>>>> hs_err/ciReplay/hotspot.log files matching.
>>>>
>>>> Thanks!
>>>>
>>>> Best regards,
>>>> Vladimir Ivanov