RFR: 8024256 Minimal VM build is broken with PCH disabled

Christian Thalinger christian.thalinger at oracle.com
Tue Sep 10 18:00:09 PDT 2013


Looks good.  -- Chris

On Sep 10, 2013, at 5:47 PM, David Holmes <david.holmes at oracle.com> wrote:

> Still need a second reviewer on this please.
> 
> Minimal VM folk in particular ;-)
> 
> Thanks,
> David
> 
> On 6/09/2013 6:49 PM, David Holmes wrote:
>> Disabling precompiled headers (PCH) has exposed a number of bugs with
>> the INCLUDE_XXX guards used by the minimal VM. In most cases a header
>> needed to be moved out of the guard or the guards removed. In one case a
>> file can be excluded completely and so its header no longer needs the
>> guard.
>> 
>> webrev: http://cr.openjdk.java.net/~dholmes/8024256/webrev/
>> 
>> Thanks,
>> David



More information about the hotspot-dev mailing list