Review Request (S) 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated

[serguei.spitsyn at oracle.com]

The updated open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.2/

Thanks,
Serguei

On 9/12/13 1:03 PM, serguei.spitsyn at oracle.com wrote:
> On 9/11/13 9:09 PM, David Holmes wrote:
>> Hi Serguei,
>>
>> This is more consistent with the surrounding code, but:
>>
>> 1. Why no RC_TRACE_WITH_THREAD for this case?
>
> Ok, I'll add tracing code.
>
>>
>> 2. If an exception is pending, that isn't OOME, shouldn't "res" 
>> already not be JVMTI_ERROR_NONE and so res should be returned in the 
>> non-OOME case?
>
> Initially it was my concern as well.
> But the only JVMTI_ERROR_OUT_OF_MEMORY and JVMTI_ERROR_INTERNAL
> are expected from the merge_cp_and_rewrite().
> So, it is better to keep it simple as in the webrev.
>
>
> Thanks,
> Serguei
>
>>
>> David
>>
>> On 12/09/2013 8:13 AM, serguei.spitsyn at oracle.com wrote:
>>>
>>> Please, review the fix for:
>>>    bug: http://bugs.sun.com/view_bug.do?bug_id=8024346
>>>    jbs: https://bugs.openjdk.java.net/browse/JDK-8024346
>>>
>>>
>>> Open webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8024346-JVMTI-MEM.1 
>>>
>>>
>>>
>>> Summary:
>>>    Pending exceptions must be handled properly after a call to the 
>>> JVMTI
>>> merge_cp_and_rewrite.
>>>
>>>
>>>
>>> Testing:
>>>    UTE tests - in progress:  vm.quick-pcl.testlist with limited
>>> Metaspace memory,
>>>                                          nsk.jvmti.testlist,
>>> nsk.jdi.testlist,
>>>                                          Jtreg java/lang/instrument
>>>
>>> Thanks,
>>> Serguei
>>>
>