Review request: 8024650: Don't adjust MaxMetaspaceSize up to MetaspaceSize

Bengt Rutisson bengt.rutisson at oracle.com
Fri Sep 13 05:47:13 PDT 2013


Looks good.

Bengt

On 9/13/13 1:55 PM, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8024650/webrev.01/
>
> Changed in this revision:
> - Removed incorrect FLAG_IS_DEFAULT check
> - Added MetaspaceSize <= MaxMetaspaceSize assert
> - Added boundary test cases where MetaspaceSize and MaxMetaspaceSize 
> is set to 0.
> - Added rudimentary tests for the new firstMatch function.
>
> Rejected proposals:
> - Use MXBeans to get flag values.
> - Use WBApi to get conservative max heap alignment.
>
> thanks,
> StefanK
>
>
> On 09/12/2013 05:18 PM, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/8024650/webrev.00/
>>
>> - Limit MetaspaceSize to MaxMetaspaceSize
>> - Make sure we don't align down to 0.
>> - jtreg test
>>
>> Note that this patch also adds/changes some functionality in the 
>> OutputAnalyzer in test/testlibrary.
>>
>> thanks,
>> StefanK
>



More information about the hotspot-dev mailing list