Review request: 8024650: Don't adjust MaxMetaspaceSize up to MetaspaceSize
Thomas Schatzl
thomas.schatzl at oracle.com
Fri Sep 13 05:54:11 PDT 2013
Hi,
On Fri, 2013-09-13 at 13:55 +0200, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8024650/webrev.01/
>
> Changed in this revision:
> - Removed incorrect FLAG_IS_DEFAULT check
> - Added MetaspaceSize <= MaxMetaspaceSize assert
> - Added boundary test cases where MetaspaceSize and MaxMetaspaceSize is
> set to 0.
> - Added rudimentary tests for the new firstMatch function.
>
> Rejected proposals:
> - Use MXBeans to get flag values.
> - Use WBApi to get conservative max heap alignment.
:)
Looks good.
Thomas
More information about the hotspot-dev
mailing list