RFR (M): 8024760: add more types, fields and constants to VMStructs

Christian Thalinger christian.thalinger at oracle.com
Fri Sep 13 12:57:48 PDT 2013


After I submitted the integration job I noticed a bug.  HeapRegion::LogOfHRGrainBytes is not a constant; it's a static field:

+     static_field(HeapRegion,                  LogOfHRGrainBytes,                             int)                                   \

-- Chris

On Sep 13, 2013, at 10:21 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> I'm going to add one more constant and then push it:
> 
> +  declare_preprocessor_constant("ASSERT", DEBUG_ONLY(1) NOT_DEBUG(0))     \
> 
> -- Chris
> 
> On Sep 12, 2013, at 7:29 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> Thank you, Vladimir.  -- Chris
>> 
>> On Sep 12, 2013, at 6:19 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>>> Good.
>>> 
>>> Vladimir
>>> 
>>> On 9/12/13 6:06 PM, Christian Thalinger wrote:
>>>> http://cr.openjdk.java.net/~twisti/8024760/webrev/
>>>> 
>>>> 8024760: add more types, fields and constants to VMStructs
>>>> Reviewed-by:
>>>> 
>>>> Some types, fields and constants we need to investigate bugs.
>>>> 
>>>> There is also a bug fix for intConstant and longConstant.  Both commands didn't print the value because the wrong name was passed.
>>>> 
>>>> agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java
>>>> src/share/vm/gc_implementation/g1/ptrQueue.hpp
>>>> src/share/vm/memory/universe.cpp
>>>> src/share/vm/memory/universe.hpp
>>>> src/share/vm/oops/klassVtable.hpp
>>>> src/share/vm/oops/methodData.hpp
>>>> src/share/vm/runtime/os.hpp
>>>> src/share/vm/runtime/vmStructs.cpp
>>>> 
>> 
> 



More information about the hotspot-dev mailing list