[8u20] RFR (XS): 8036619: Shark: add LLVM 3.4 support

Christian Thalinger christian.thalinger at oracle.com
Mon Apr 7 21:25:16 UTC 2014


On Apr 7, 2014, at 2:04 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> On 4/7/14 1:59 PM, Vladimir Kozlov wrote:
>> On 4/7/14 1:08 PM, Christian Thalinger wrote:
>>> 
>>> On Apr 7, 2014, at 1:02 PM, Vladimir Kozlov
>>> <vladimir.kozlov at oracle.com> wrote:
>>> 
>>>> Hotspot changes does not require approval on jdk8u-dev. Alejandro
>>>> does bulk requests.
>>> 
>>> That’s true but in this case I thought it might not hurt.  Do all
>>> HotSpot backports require no approval no matter how big they are?
> 
> I did NOT request an approval for PPC64 backport, Alejandro did it for me :)

Ok, that’s a clear precedent :-)

> 
> Regards,
> Vladimir
> 
>> 
>> I think, we should be notified what is backported.
>> The only document we have is Alejandro's mail:
>> 
>> > The process to get hotspot changes for 8u20 is the same
>> > as the one to get changes for 7u releases. In a nutshell:
>> >
>> > (1) Request a review (not permission) on hotspot-dev at openjdk
>> > (2) Push to jdk8u/hs-dev/hotspot (via jprt)
>> > (3) NO NEED TO REQUEST approval for integration
>> >
>> > once the changes are in hs-dev, I will push then to the master after PIT
>> > and I will request the approval for a bulk integration then
>> 
>> So it is not, technically, an approval but a notification and review.
>> It is always good to have other people look on your changes.
>> 
>> Thanks,
>> Vladimir
>> 
>>> 
>>>> 
>>>> Mario, your changes are good. Christian, can you sponsor backport?
>>>> 
>>>> 8u20 hotspot staging repo is:
>>>> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot
>>>> 
>>>> Thanks,
>>>> Vladimir
>>>> 
>>>> On 4/7/14 12:52 PM, Christian Thalinger wrote:
>>>>> You need to send a request for approval to jdk8u-dev.
>>>>> 
>>>>> On Apr 7, 2014, at 12:51 AM, Mario Torre <neugens at redhat.com> wrote:
>>>>> 
>>>>>> On Mon, 2014-03-17 at 14:15 +0100, Mario Torre wrote:
>>>>>>> Resending with correct webrev and subject :)
>>>>>>> 
>>>>>>> I would like to ask the backport of the changes made for the
>>>>>>> following
>>>>>>> bug report into JDK 8 (jdk8u20):
>>>>>>> 
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8036619
>>>>>>> 
>>>>>>> The changes apply cleanly without modification:
>>>>>>> 
>>>>>>> http://cr.openjdk.java.net/~neugens/zero-2014-02-24/webrev.03/
>>>>>>> 
>>>>>>> The related changes for JDK 9 are here:
>>>>>>> 
>>>>>>> http://cr.openjdk.java.net/~neugens/zero-2014-02-24/webrev.02/
>>>>>>> 
>>>>>>> The discussion here:
>>>>>>> 
>>>>>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-March/012814.html
>>>>>>> 
>>>>>>> 
>>>>>>> and here:
>>>>>>> 
>>>>>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-February/012679.html
>>>>>>> 
>>>>>>> 
>>>>>>> I can't push myself, so if OK, someone would need to do for me.
>>>>>>> 
>>>>>>> Cheers,
>>>>>>> Mario
>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> ping?
>>>>>> 
>>>>>> Cheers,
>>>>>> Mario
>>>>>> 
>>>>> 
>>> 



More information about the hotspot-dev mailing list