[9] RFR(L): 8037816 : Fix for 8036122 breaks build with Xcode5/clang

[David Chase]

On 2014-04-17, at 6:27 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:

> These PRAGMA_FORMAT_NONLITERAL_IGNORED macros are gross.  I can't believe they complain if the format string is const char*.   Can you replace some like the ones in metaspace.cpp at least with macros?

i.e., #define fmt ... ?

and how does Christian feel about this?

I think the reason the "const char * = constant" does not fly has to do with the nature of the format checking;
it happens early, before terribly much flow analysis occurs.

David