Review-Request: Fix of JDK-8034775 neglects to account for non-JIT VMs

Severin Gehwolf sgehwolf at redhat.com
Wed Apr 30 07:30:50 UTC 2014


On Tue, 2014-04-29 at 09:54 -0700, Vladimir Kozlov wrote:
> Hi Severin,
> 
> Is it your final webrev?:
> 
> http://jerboaa.fedorapeople.org/bugs/openjdk/JI-9011998/v2/

Yes. The change in src/share/vm/runtime/globals.hpp is not needed as
David pointed out.

Thanks,
Severin

> On 4/29/14 4:34 AM, Severin Gehwolf wrote:
> > On Tue, 2014-04-29 at 13:09 +0200, Severin Gehwolf wrote:
> > [...]
> >> As to why the if on line 167 is entered I'm still unsure. Apparently one
> >> of COMPILER1, COMPILER2, SHARK is defined for a --with-jvm-variants=zero
> >> build. It's not apparent to me which it is and why :-/
> >
> > Well scratch that. It appears I've not had enough coffee today. Sorry
> > for the noise.
> >
> > Cheers,
> > Severin
> >





More information about the hotspot-dev mailing list