RFR(XXS): 8056175: Change "8048150: Allow easy configurations for large CDS archives" triggers conversion warning with older GCC

[Volker Simonis]

Hi Calvin, Coleen,

thanks a lot for the ultra-fast reviewing and pushing!

@Calvin: just as a side node, 'hg import', 'hg commit' and 'hg
qrefresh' can all be used with the '-u <username>' option. That way
you can set the authors user name and avoid the necessity to have an
extra "Contributed-by:" line for contributors who already are OpenJDK
authors.

Regards,
Volker


On Wed, Aug 27, 2014 at 6:46 PM, Calvin Cheung <calvin.cheung at oracle.com> wrote:
> Hi Volker,
>
> Your fix looks good and thanks for fixing it.
> I can sponsor your fix after another 'R'eviewer has reviewed it.
>
> thanks,
> Calvin
>
>
> On 8/27/2014 7:58 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> could somebody please review and sponsor the following tiny change
>> which fixes the HotSpot build on older versions of GCC after change
>> "8048150: Allow easy configurations for large CDS archives":
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8056175/
>> https://bugs.openjdk.java.net/browse/JDK-8056175
>>
>> For GCC versions before 4.3 we still use the "-Wconversion" flag so if
>> we build with such a GCC the code introduced by "8048150: Allow easy
>> configurations for large CDS archives" will trigger the following
>> warnings which are treated as errors:
>>
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp: In static
>> member function 'static void
>> MetaspaceShared::estimate_regions_size()':
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1124: warning:
>> converting to 'uintx' from 'double'
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1125: warning:
>> converting to 'uintx' from 'double'
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1126: warning:
>> converting to 'uintx' from 'double'
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1127: warning:
>> converting to 'uintx' from 'double'
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1129: warning:
>> converting to 'uintx' from 'double'
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1130: warning:
>> converting to 'uintx' from 'double'
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1131: warning:
>> converting to 'uintx' from 'double'
>> /src/hotspot-rt/src/share/vm/memory/metaspaceShared.cpp:1132: warning:
>> converting to 'uintx' from 'double'
>>
>> The fix is trivial - just implicitly cast the result of the conversion to
>> uintx.
>>
>> Thank you and best regards,
>> Volker
>
>