RFR 8056084: Refactor Hashtable to allow implementations without rehashing support
Thomas Schatzl
thomas.schatzl at oracle.com
Fri Aug 29 11:59:53 UTC 2014
Hi Mikael,
On Thu, 2014-08-28 at 13:20 +0200, Bengt Rutisson wrote:
> Hi Mikael,
>
> >> One very minor nit if you feel like it.
> >>
> >> hashtable.cpp
> >> 50 if (_free_list) {
> >>
> >> Would you mind changing to "if (_free_list != NULL) {" ? I know it is
> >> not your code, but you are changing code in that method and did take me
> >> some extra brain cycles to realize that _free_list was not a bool
> >> indicating whether we were using a free list or not.
> >
> > That seems like a good suggestion. The HotSpot style also explicitly
> > mentions that using pointers as booleans should be avoided.
> >
> > New webrev at:
> > http://cr.openjdk.java.net/~mgerdin/8048268/hashtable-refactor/webrev.1/
>
Looks good to me.
Thomas
More information about the hotspot-dev
mailing list