[9] RFR(S): 8066433: Copy Whitebox testlibrary to /jdk/test

[Staffan Larsen]

> On 2 dec 2014, at 20:25, Staffan Larsen <staffan.larsen at oracle.com> wrote:
> 
> 
>> On 2 dec 2014, at 18:37, Tobias Hartmann <Tobias.Hartmann at oracle.com> wrote:
>> 
>> Hi Mikael,
>> 
>> On 02.12.2014 18:22, Mikael Vidstedt wrote:
>>> 
>>> Tobias,
>>> 
>>> Have you looked at what it would take to move the testlibrary somewhere where it
>>> can actually be shared instead? I think it would be extremely unfortunate to
>>> copy the code. I can't stress that enough.
>> 
>> I agree that having the testlibrary in a shared location is definitely the best
>> solution. Unfortunately, I don't know how to do that since we have to access the
>> library from different repositories and I don't think we want to have path
>> dependencies between the repositories.
>> 
>> Any suggestions?
> 
> jtreg currently requires the testlibrary to be located in or under the directory with the TEST.ROOT file. To move it somewhere else we need to change jtreg first - and I think we should.

I’ve been told that it is actually possible to do this with the current jtreg by using an ugly path such as:

   @library /../../test/testlibrary

I don’t think that is what we want to do…

/Staffan


> 
> /Staffan
> 
>> 
>> Thanks,
>> Tobias
>> 
>>> 
>>> Cheers,
>>> Mikael
>>> 
>>> On 2014-12-02 06:40, Tobias Hartmann wrote:
>>>> Hi,
>>>> 
>>>> please review the following patch that copies the Whitebox testlibrary to
>>>> /jdk/test. This is needed to enhance and fix jdk tests (for example, see [1]).
>>>> 
>>>> The change leads to code duplication but in my opinion we should favour stable
>>>> tests over code duplication here. Hopefully, there is a solution to share the
>>>> library in the future.
>>>> 
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8066433
>>>> Webrev: http://cr.openjdk.java.net/~thartmann/8066433/webrev.00/
>>>> 
>>>> Thanks,
>>>> Tobias
>>> 
>