8067452: Rename hotspot_all in hotspot/test/TEST.groups

David Holmes david.holmes at oracle.com
Tue Dec 16 08:04:06 UTC 2014


On 16/12/2014 5:20 PM, 'Erik Helin' wrote:
> On 2014-12-16, David Holmes wrote:
>> Is this a stepping stone to having JPRT execute hotspot_jprt?
>
> Unfortunately no, we need the parallelism we gain from specifying the
> targets individually in the top-level make/jprt.properties file.

Ah right - so this is only to be able to run stand-alone what JPRT would 
run?

>> You don't really need a group to represent "all" as that is what you get if
>> you don't specify any group or a specific test. But it is harmless I
>> suppose.
>
> The group hotspot_all is convenient when running the JTReg tests from
> the top-level Makefile. If you run configure with
> "--with-jtreg=/path/to/jtreg", you can now run
>
>    $ make test TEST=hotspot_all
>
> at the top-level to run all JTReg tests in the hotspot/test folder (and
> subfolders).

Got it - it's a make target more than anything.

Thanks,
David

> Thanks,
> ERik
>
>> Thanks,
>> David
>>
>> On 16/12/2014 4:32 AM, Christian Tornqvist wrote:
>>> Hi Erik,
>>>
>>> This looks good.
>>>
>>> Thanks,
>>> Christian
>>>
>>> -----Original Message-----
>>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of
>>> Erik Helin
>>> Sent: Monday, December 15, 2014 12:19 PM
>>> To: hotspot-dev at openjdk.java.net
>>> Subject: RFR: 8067452: Rename hotspot_all in hotspot/test/TEST.groups
>>>
>>> Hi all,
>>>
>>> this small patch renames the test group hotspot_all in
>>> hotspot/test/TEST.groups to hotspot_jprt to better reflect its purpose.
>>> I also synced the new test group hotspot_jprt with the top-level
>>> make/jprt.properties file, so that hotspot_jprt includes as many of the
>>> JTReg tests we run in JPRT as possible.
>>>
>>> I also added a new test group hotspot_all that actually is *all* the tests
>>> under hotspot/test.
>>>
>>> Please note that this will not affects which tests are being run in JPRT,
>>> that is still decided by the top-level file make/jprt.properties.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8067452/webrev.00/
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8067452
>>>
>>> Testing:
>>> - Run `make test TEST=hotspot_all` on Linux x86-64
>>> - Run `make test TEST=hotspot_jprt` on Linux x86-64
>>>
>>> Thanks,
>>> Erik
>>>


More information about the hotspot-dev mailing list