RFR: 8067713: Move clean_weak_method_links for redefinition out of class unloading

[Coleen Phillimore]

Kim,

Thank you for the code review.

On 12/18/14, 4:01 PM, Kim Barrett wrote:
> On Dec 17, 2014, at 1:05 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>> Summary: Do this work during class redefinition, only verify clean during class unloading in debug mode.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8067713/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8067713
> Looks good, except for some comment issues:
>
> ------------------------------------------------------------------------------
> src/share/vm/oops/instanceKlass.cpp
>
> 3546 #ifdef ASSERT
> 3547             if (method->method_data() != NULL) {
> 3548               // Clean out any weak method links for running methods
> 3549               // (also should include not EMCP methods)
> 3550               method->method_data()->verify_clean_weak_method_links();
> 3551             }
> 3552 #endif // ASSERT
>
> Comment needs to be updated.  This no longer cleans, it verifies
> cleaning has been done.

               // Verify MethodData for running methods don't refer to 
old methods.

I left out EMCP methods part, that was referring to a former bug that 
was in this code.
>
> ------------------------------------------------------------------------------
> src/share/vm/oops/instanceKlass.cpp
>
> 3566 #ifdef ASSERT
> 3567   // Verify clean MethodData of this class's methods so they don't refer to
> 3568   // old methods that are no longer running.
>
> This comment is now poorly worded; suggest something like
>
>     // Verify clean MethodData for this class's methods, e.g. they don't refer to
>     // old methods that are no longer running.

Sure.  I changed it.

I changed the both occurences of "index2".

Coleen


>
> [Someone else already complained about index2 near here.]
>
> ------------------------------------------------------------------------------
>