RFR: 8032010: Attempt to resolve abstract method in concrete class fails with AbstractMethodError

Lois Foltan lois.foltan at oracle.com
Mon Feb 3 15:48:51 PST 2014


Hi Calvin,

- src/share/vm/interpreter/linkResolver.cpp
   Looks good, no comments.

- test/runtime/lambda-features/TestConcreteClassWithAbstractMethod.java
   Looks good.  Please update the comments that contain the pseudo Java 
code describing
   the test's purpose.  The comments need to reflect that the callsite 
to the method of interest, "m()",
   actually occurs within p1.T3's "test()" method.

Thank you,
Lois

On 1/31/2014 5:45 PM, Calvin Cheung wrote:
> This change, by removing a check in LinkResolver::resolve_method(), is 
> to conform with the recent change in JVMS-8 [1].
> The following check during method resolution is removed:
> JVMS-5.4.3.3. Method Resolution
> "If method lookup succeeds and the method is abstract, but C is not 
> abstract, method resolution throws an AbstractMethodError."
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8032010
>
> webrev: http://cr.openjdk.java.net/~ccheung/8032010/webrev/
>
> tests: (on linux-x64)
>     vm.quick
>     jck vm and lang
>     jtreg on java/util/stream and the new testcase
>     defmeth
>     jprt
>
> thanks,
> Calvin
>
> [1] http://cr.openjdk.java.net/~dlsmith/jsr335-0.9.1.html#J



More information about the hotspot-dev mailing list