RFR(S): JDK-8016644 - Improve UnsupportedClassVersionError message

[Christian Thalinger]

On Feb 7, 2014, at 3:47 AM, Christian Tornqvist <christian.tornqvist at oracle.com> wrote:

> Expanding this to hotspot-dev since I’m making changes to test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java as part of this change.

Thanks for doing that change.

>  
> Updated the exception message and modified the test to allow options sent via –vmoption/-vmoptions in jtreg to be passed to the spawned Java process.
>  
> New webrev at:
> http://cr.openjdk.java.net/~ctornqvi/webrev/8016644/webrev.01/
>  
> Thanks,
> Christian
>  
> From: Christian Thalinger [mailto:christian.thalinger at oracle.com] 
> Sent: Thursday, February 6, 2014 4:46 PM
> To: Christian Tornqvist
> Cc: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(S): JDK-8016644 - Improve UnsupportedClassVersionError message
>  
> I respectfully disagree.  If I want to e.g. run all tests in interpreted mode for whatever reason (maybe there is a bug in the compiler and I want to see if it happens in interpreted mode too) then I want ALL tests to run with the flags I specify.  No matter what they do.
>  
> On Feb 6, 2014, at 1:19 PM, Christian Tornqvist <christian.tornqvist at oracle.com> wrote:
> 
> 
> Hi Chris,
>  
> This is one of those tests that doesn’t need any of the extra options, we’re simply verifying the error message. There are several cases where we shouldn’t pass the flags and I think this might be one of them.
>  
> Thanks,
> Christian
>  
> From: Christian Thalinger [mailto:christian.thalinger at oracle.com] 
> Sent: Wednesday, February 5, 2014 11:03 PM
> To: Christian Tornqvist
> Cc: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(S): JDK-8016644 - Improve UnsupportedClassVersionError message
>  
> Not so much about this particular change but the way testing is done.  I don’t really like how we are spawning other Java processes:
>   41         ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-cp", ".",  "ClassFile");
> As far as I can see there is no code that passes on the flags which are defined with either -vmoption or JAVA_VM_ARGS.  If I tell the testing framework to use a particular flag then I expect all Java processes to use them.
>  
> Can we please change that?
>  
> On Feb 5, 2014, at 7:19 PM, Christian Tornqvist <christian.tornqvist at oracle.com> wrote:
> 
> 
> 
> Hi everyone,
>  
> This change is about making the UnsupportedClassVersionError message a bit more user friendly.
>  
> Webrev can be found at:
> http://cr.openjdk.java.net/~ctornqvi/webrev/8016644/webrev.00/
>  
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8016644
>  
> Thanks,
> Christian