RFR(M): 8034080 Remove the USDT1 dtrace code from Hotspot

[Coleen Phillimore]

Ship it + 1. thank you for doing this change!
Coleen

On 2/17/14 8:56 AM, David Holmes wrote:
> Ship it! :)
>
> David
>
> On 17/02/2014 5:38 PM, Staffan Larsen wrote:
>>
>> On 17 feb 2014, at 02:44, David Holmes <david.holmes at oracle.com> wrote:
>>
>>> src/share/vm/prims/jni.cpp
>>>
>>> Indent is wrong here:
>>>
>>> JNI_ENTRY(jobject, jni_NewGlobalRef(JNIEnv *env, jobject ref))
>>>     JNIWrapper("NewGlobalRef");
>>> !
>>> ! HOTSPOT_JNI_NEWGLOBALREF_ENTRY(env, ref);
>>> !
>>
>> Sharp eyes! Fixed.
>>
>>> Is it worth renaming 
>>> src/share/vm/utilities/dtrace_usdt2_disabled.hpp to just 
>>> src/share/vm/utilities/dtrace_disabled.hpp ? Or maybe even fold the 
>>> content back into dtrace.hpp
>>
>> Good point. Given how large (and boring) it is I kept it as a 
>> separate file but renamed it.
>>
>>> Otherwise looks good to see this all get stripped out!
>>
>> Updated webrev: http://cr.openjdk.java.net/~sla/8034080/webrev.01/
>>
>> Thanks,
>> /Staffan
>>
>>>
>>> Thanks,
>>> David
>>>
>>>
>>>
>>> On 11/02/2014 8:12 PM, Staffan Larsen wrote:
>>>> Now that both the Solaris (JDK-8030812) and the Linux (JDK-8032462) 
>>>> implementations have moved to USDT2, we can finally remove the 
>>>> USDT1 code from hotspot.
>>>>
>>>> There are quite a lot of changes in this review, and webrev barfed 
>>>> on the number of change in jni.cpp so that file can only be 
>>>> reviewed from the patch file. The good news is that the changes are 
>>>> mostly trivial removal of #ifdef:ed code.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8034080
>>>> webrev: http://cr.openjdk.java.net/~sla/8034080/webrev.00/
>>>>
>>>> Testing: I have run jck-runtime, vm.quick.testlist and 
>>>> vm.dtrace.testlist on Solaris and OS X.
>>>>
>>>> /Staffan
>>>>
>>