JDK-8022203 - Intermittent test failures in demo/jvmti/hprof

[Staffan Larsen]

This change is in the jdk, not in hotspot. Only one Reviewer is required for jdk changes. However, the review request should have been sent to serviceability-dev at openjdk.java.net instead of hotspot-dev, sorry I missed that. Also, the changes need to go first into jdk9 and then backported to jdk8 (if needed). So the correct repo for the push is jdk9-dev.

Thanks,
/Staffan


On 20 feb 2014, at 08:18, Sergei Kovalev <sergei.kovalev at oracle.com> wrote:

> Hello Team,
> 
> Could somebody else take a look? I need one more approval.
> 
> 18.02.2014 14:04, Staffan Larsen пишет:
>> Looks good!
>> 
>> Thanks,
>> /Staffan
>> 
>> On 17 feb 2014, at 13:32, Sergei Kovalev <sergei.kovalev at oracle.com> wrote:
>> 
>>> Hello everyone,
>>> 
>>> I'm working for https://bugs.openjdk.java.net/browse/JDK-8022203.
>>> 
>>> As it was discussed, I prepared fix for the issue: http://cr.openjdk.java.net/~anazarov/8022203/webrev.01/
>>> 
>>> The failure caused by slippage in IO operation due to file system performance. To avoid this situation we will use an unique file name for profiling dump. In this case we will have zero probability that tests would overlapped by output file. By default the file name for dump output builds from library name plus .java. prefix and .txt suffix. Hprof tool supports "file" option that used for providing the output file name. Therefore we can just add unique file name to options string for each individual tests that used hprof.
>>> 
>>> Testing done:
>>> - single run of tests
>>> - Stability run of all modified tests
>>> - Modified stability run. I did some test modification that helped me to increase reproducibility rating. It was 500-1000 iteration instead 10,000 in original case. Test with modified options string ran 10,000 iteration.
>>> 
>>> Could you please approve fix?
>>> 
>>> -- 
>>> With best regards,
>>> Sergei
>>> 
> 
> -- 
> With best regards,
> Sergei
>