RFR(S): 8035396: Introduce accessor for tmp_oop in frame.

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Feb 20 02:58:41 PST 2014


Hi,

Access to the tmp_oop in a frame is done with several #ifdefs
distinguishing the platforms and interpreters. The PPC64 template
interpreter would introduce another one.

This change avoids the #ifs by introducing the accessor function
interpreter_frame_temp_oop_addr() as for many other fields in the frame.

Unfortunately this will require to implement interpreter_frame_temp_oop_addr()
in the closed sources I can not do.  As the platform file for frame.hpp has
to be changed anyways, I propose to also move
#ifdef PPC32
oop* interpreter_frame_mirror_addr() const;
#endif
from frame.hpp into frame_ppc.hpp in the closed port.

Please review and test this change.
http://cr.openjdk.java.net/~goetz/webrevs/8035396-1-tmpOop/


This change should also go to jdk8u.  It's fine if this happens some later if the
path via ppc-aix-port/stage is not possible due to the closed change.

Best regards,
  Goetz.


More information about the hotspot-dev mailing list