RFR(XS): 8035392: cppInterpreter: fix message of NPE

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Feb 20 13:55:54 PST 2014


Thanks for the review, Coleen and Vladimir!

Best regards,
 Goetz.

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
Sent: Thursday, February 20, 2014 9:07 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(XS): 8035392: cppInterpreter: fix message of NPE


+1.
Coleen

On 2/20/14 2:08 PM, Vladimir Kozlov wrote:
> Looks good.
>
> Thanks,
> Vladimir
>
> On 2/20/14 2:13 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> we fixed an issue with the cpp interpreter.
>>
>> It generates a NullPointerException with "" as message. Jck test
>> api/java_util/Objects/index.html#RequireNonNullMessageSupplier expects
>> NULL. This is also what the template interpreter uses.
>>
>> Fix: change "" to NULL.
>> http://cr.openjdk.java.net/~goetz/webrevs/8035392-1-nullMsg/
>>
>> Please review and test this change.  It also needs to go to
>> jdk8u via ppc-aix-port/stage.
>>
>> Best regards,
>>    Goetz.
>>



More information about the hotspot-dev mailing list