JDK9: RFR: 8033898: undefined symbol when build hotspot with Xcode5

[David Holmes]

On 27/02/2014 4:17 AM, Henry Jen wrote:
> Thanks, Staffan.
>
> Need another review before push to hotspot. Would it be OK for hotspot
> team if we push this through jdk9/dev?

Looks okay to me. Can't approve/not-approve the push to jdk9/dev though 
- but as long as it goes through JPRT I do not see an issue, as it only 
affects building with a compiler we don't officially use.

David

> As this is a build change only, and it would be nice to have 9dev build
> on Xcose once we have other pieces in instead of waiting for hostpot
> integration.
>
> Cheers,
> Henry
>
> On 02/26/2014 12:24 AM, Staffan Larsen wrote:
>> Looks good!
>>
>> Thanks,
>> /Staffan
>>
>> On 26 feb 2014, at 09:08, Henry Jen <henry.jen at Oracle.com> wrote:
>>
>>> Hi,
>>>
>>> Please review a simple webrev that ensure we link with libstdc++ when
>>> using clang instead of libc++, libc++ is default for Xcode5.
>>>
>>> Per clang man page,
>>>
>>>>        -stdlib=library
>>>>            Specify the C++ standard library to use; supported
>>>> options are
>>>>            libstdc++ and libc++.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8033898
>>> Webrev: http://cr.openjdk.java.net/~henryjen/jdk9/8033898/1/webrev/
>>>
>>> Cheers,
>>> Henry
>>