Changing lots of files - mainly GC code

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Jan 13 05:07:26 PST 2014


Hi Kris!

No problem, I'll add it to the change. Please verify that it looks OK in the 
updated webrev (same link as before).

http://cr.openjdk.java.net/~jwilhelm/8025856/webrev.1/

/Jesper


Krystal Mok skrev 10/1/14 7:17 PM:
> Hi Jesper,
>
> Nice to see cleaner code!
>
> Hitchhike: It'd be nice if you could include this typo in:
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-January/012944.html
> I didn't really like sending one-liner comment typo fix anyway...with a lot of
> other typos, the story is different ;-)
>
> Thanks,
> Kris
>
>
>
> On Fri, Jan 10, 2014 at 11:54 PM, Coleen Phillmore <coleen.phillimore at oracle.com
> <mailto:coleen.phillimore at oracle.com>> wrote:
>
>     Seems fine with me also.  Could you find typos in the comments in the
>     runtime code "by accident" too? :)
>     thanks,
>     Coleen
>
>
>     On 1/10/2014 10:39 AM, Daniel D. Daugherty wrote:
>
>         On 1/10/14 5:49 AM, Jesper Wilhelmsson wrote:
>
>             Hi,
>
>             I have a change out for review that fixes a huge pile of typos in
>             the comments in the GC code. The RFR was sent to the GC list, but I
>             want to give a heads up in case anyone else is changing GC code and
>             want to avoid merge conflicts.
>
>             The patch: http://cr.openjdk.java.net/~__jwilhelm/8025856/webrev.1/
>             <http://cr.openjdk.java.net/~jwilhelm/8025856/webrev.1/>
>
>
>             There are also a few files where I happened to find a few typos "by
>             accident" in code that is not strictly GC code. These are:
>
>             src/share/vm/memory/heap.cpp
>             src/share/vm/memory/heap.hpp
>             src/share/vm/memory/__allocation.hpp
>             src/share/vm/memory/__resourceArea.hpp
>             src/share/vm/runtime/thread.__cpp
>
>             There is a total of eight typos fixed in these files so I think the
>             risk of merge conflicts here is minimal. Are there any objections to
>             including these fixes in the change?
>
>
>         Vote: go for it!
>
>         Dan
>
>
>             Thanks,
>             /Jesper
>
>
>
>


More information about the hotspot-dev mailing list