RFR: JDK9: 8028407: adjust-mflags.sh failed build with GNU Make 4.0 with -I<path contains j>
Henry Jen
henry.jen at oracle.com
Wed Jan 22 08:28:57 PST 2014
I need to know better for hotspot process, which is why I was looking
for a sponsor. Hopefully to adress the concerns,
- I had done jprt before the push
- This patch had been looked at in the past, hopefully I can count David
as another reviewer as he understood this issue from last discussion.
Cheers,
Henry
On 01/21/2014 11:07 PM, David Holmes wrote:
> Henry,
>
> hotspot changes also traditionally require two reviewers, unlike
> core-libs. Though given the rules are now set by the jdk9 project it
> isn't clear how that can be enforced :(
>
> David
>
> On 22/01/2014 4:55 PM, Alejandro E Murillo wrote:
>>
>> On 1/21/2014 9:47 PM, Henry Jen wrote:
>>> On 01/21/2014 04:34 PM, Alejandro E Murillo wrote:
>>>>
>>>> On 1/21/2014 11:20 AM, Henry Jen wrote:
>>>>>
>>>>> On 01/20/2014 04:54 AM, Erik Joelsson wrote:
>>>>>> I suggested the change back then and even though I had to think for a
>>>>>> while to figure out what it did, it still looks correct.
>>>>>>
>>>>>> As for pushing, as a jdk9 committer, it is my understanding that
>>>>>> you are
>>>>>> allowed to push it yourself to Hotspot, as long as you use Jprt and
>>>>>> push
>>>>>> to the correct group repo.
>>>>>>
>>>>>
>>>>> Cool, I will do that and push to jdk9/dev/hotspot.
>>>> you should push this to a hotspot group repo.
>>>> I suggest you push it to: jdk9/hs-rt/hotspot
>>>>
>>>
>>> Sorry I had pushed this before read this email, I assume the
>>> propagation will happen eventually.
>>>
>>> Also I think it won't hurt if anyone in hotspot group would like to
>>> cherry-pick that particular changeset.
>>>
>>> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/e8d4d0db1f06
>>>
>>> Apologize if this cause any inconvinience.
>>>
>>> Cheers,
>>> Henry
>> Erik's email, that you replied, indicated that this should have
>> been pushed to the right repo and using JPRT.
>> doesn't look like you used JPRT to push this change either,
>> Hotspot changes must be pushed using JPRT.
>>
>> the propagation will happen, but the problem is that
>> it won't get proper nightly or PIT testing on that repo before
>> going to master.
>>
>> If you didn't push using JPRT, then please run a non pushing hotspot
>> job to verify all the bundles, including embedded ones, are building
>> without problem.
>>
>> Thanks
>>
More information about the hotspot-dev
mailing list