RFR: 8033057: clang: friend declaration specifying a default argument must be a definition
Coleen Phillimore
coleen.phillimore at oracle.com
Fri Jan 31 11:52:17 PST 2014
Henry,
This seems fine but you need to check these changes into one of the
hotspot team repositories, ie: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot
through JPRT. Let me know if you have any questions.
Thanks,
Coleen
On 1/30/14 5:54 PM, Henry Jen wrote:
> Hi,
>
> Please review a fix on an error reported by clang 3.4.
>
> http://cr.openjdk.java.net/~henryjen/jdk9/8033057/webrev/
>
> The fix is to be comforming to C++ 11 spec, quoted,
>
> C++11: §8.3.6.4
> "If a friend declaration specifies a default argument expression,
> that declaration shall be a definition and shall be the only declaration
> of the function or function template in the translation unit."
>
> A working draft for C++ 11 can be found at
> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3376.pdf
>
> Cheers,
> Henry
More information about the hotspot-dev
mailing list